fix(web): fix bugs in createDefaultKeep, extend unit testing 🚂#15950
Draft
jahorton wants to merge 10 commits into
Draft
fix(web): fix bugs in createDefaultKeep, extend unit testing 🚂#15950jahorton wants to merge 10 commits into
jahorton wants to merge 10 commits into
Conversation
This method is designed to determine the appropriate range of tokens, within each context variant, should be eligible for correction when generating predictions and corrections. Build-bot: skip build:web Test-bot: skip
Build-bot: skip build:web Test-bot: skip
To better handle inputs that shift the word-boundary in some custom models and models released before Keyman 14.0, this PR provides generalized re-use of the whitespace-based token-transition algorithm used for our most prominently-supported models. Build-bot: skip build:web Test-bot: skip
…rection Build-bot: skip build:web Test-bot: skip
Lack of this string can break auto-correction and casing behaviors - and actually _did_ within engine/main!
…ract-whitespace-tokenization-mapping
…to change/web/rework-traversalless-prediction
It turns out that #15766 did not perfectly address all cases for generation of default "keep" suggestions. This PR will remedy the situation. Build-bot: skip build:web Test-bot: skip
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
keymanapp-test-bot
Bot
changed the title
jahorton
force-pushed
the
change/web/rework-traversalless-prediction
branch
from
dacfc13 to
8227b81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that #15766 did not perfectly address all cases for generation of default "keep" suggestions. This PR will remedy the situation.
Build-bot: skip build:web
Test-bot: skip